This repository has been archived by the owner on Dec 3, 2019. It is now read-only.
Fix pyflame for code compiled with ld -z separate-code #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This fixes pyflame on 3.6 (including 3.6.6+) for me. It won't work for 3.7 because there is no # define _PyThreadState_Current _PyRuntime.gilstate.tstate_current I'll try to have a look at that later on. |
randomstuff
force-pushed
the
fix_separate_code
branch
2 times, most recently
from
2ea2894
to
26bd8b1
Compare
This was referenced Feb 28, 2019
randomstuff
changed the title
separate-code generates VAS layouts like this: 555555554000-5555555a8000 r--p 00000000 08:02 919707 /opt/python-3.6.8/bin/python3.6 5555555a8000-55555573d000 r-xp 00054000 08:02 919707 /opt/python-3.6.8/bin/python3.6 55555573d000-5555557ce000 r--p 001e9000 08:02 919707 /opt/python-3.6.8/bin/python3.6 5555557cf000-555555835000 rw-p 0027a000 08:02 919707 /opt/python-3.6.8/bin/python3.6 555555835000-555555865000 rw-p 00000000 00:00 0 [heap] 7ffff7fd0000-7ffff7fd3000 r--p 00000000 00:00 0 [vvar] 7ffff7fd3000-7ffff7fd5000 r-xp 00000000 00:00 0 [vdso] 7ffff7fd5000-7ffff7fd6000 r--p 00000000 08:02 265255 /lib/x86_64-linux-gnu/ld-2.28.so 7ffff7fd6000-7ffff7ff4000 r-xp 00001000 08:02 265255 /lib/x86_64-linux-gnu/ld-2.28.so 7ffff7ff4000-7ffff7ffc000 r--p 0001f000 08:02 265255 /lib/x86_64-linux-gnu/ld-2.28.so 7ffff7ffc000-7ffff7ffe000 rw-p 00026000 08:02 265255 /lib/x86_64-linux-gnu/ld-2.28.so 7ffff7ffe000-7ffff7fff000 rw-p 00000000 00:00 0 7ffffffde000-7ffffffff000 rw-p 00000000 00:00 0 [stack] This is enabled by default on Linux/x86 since 2.29 (f6aec96dce1ddbd8961a3aa8a2925db2021719bb).
randomstuff
force-pushed
the
fix_separate_code
branch
from
26bd8b1
to
739a77d
Compare
|
This makes pyflame usable again for me with python 2.7.16 (debian buster), will this be merged ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generates VAS layouts like this:
This is enabled by default on Linux/x86 since 2.29
(f6aec96dce1ddbd8961a3aa8a2925db2021719bb).